Style overhaul #64
Merged
Style overhaul #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wjwwood FYI: This should be style change only, but given that amount of change I could use another set of eyes to sanity check that these are actually impacting only style |
wjwwood
approved these changes
Nov 14, 2017
mikaelarguedas
force-pushed
the
style_overhaul
branch
from
b754010
to
b27b9aa
Compare
|
thanks @wjwwood for the quick review, rebased and ci green, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the ros2 style to class loader before branching out for melodic. This will allow easier backports the future.
Violations ignored in this PR:
missing copyright: contacted contributors and will update accordingly
ABI breaking changes (explicit constructors)